Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonApi: define contact accounts sideloads on GroupResource #2554

Merged
merged 3 commits into from Apr 19, 2024
Merged

JsonApi: define contact accounts sideloads on GroupResource #2554

merged 3 commits into from Apr 19, 2024

Conversation

daniel-illi
Copy link
Contributor

fixes #2537

@daniel-illi daniel-illi force-pushed the feature/2537-jsonapi-group-contactaccounts branch 8 times, most recently from c7e9e4e to 341e51a Compare April 12, 2024 12:59
@daniel-illi daniel-illi linked an issue Apr 12, 2024 that may be closed by this pull request
GROUPS: Contactable Daten der Gruppe in Gruppen-API #2537
Closed
5 tasks
@daniel-illi daniel-illi marked this pull request as ready for review April 12, 2024 14:13
mtnstar
mtnstar requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good ... some comments to check ...

app/abilities/group_details_readables.rb Show resolved Hide resolved
app/abilities/group_readables.rb Outdated Show resolved Hide resolved
app/abilities/json_api/contact_account_ability.rb Show resolved Hide resolved
@mtnstar
Copy link
Member

mtnstar commented Apr 15, 2024

a documentation around json:api vs. permissions would be very helpful I think

@mtnstar
Copy link
Member

mtnstar commented Apr 15, 2024

I think there's also a newer graphiti release ... does it make sense to upgrade it together with this PR?

@kronn kronn deleted the branch master April 15, 2024 13:42
@kronn kronn closed this Apr 15, 2024
@daniel-illi daniel-illi reopened this Apr 16, 2024
@daniel-illi daniel-illi changed the base branch from sac-master to master April 16, 2024 08:41
@daniel-illi daniel-illi force-pushed the feature/2537-jsonapi-group-contactaccounts branch from 341e51a to 244101c Compare April 19, 2024 13:56
@daniel-illi daniel-illi force-pushed the feature/2537-jsonapi-group-contactaccounts branch from 244101c to b986a23 Compare April 19, 2024 13:56
@daniel-illi daniel-illi merged commit 07596f8 into master Apr 19, 2024
7 of 10 checks passed
@daniel-illi daniel-illi deleted the feature/2537-jsonapi-group-contactaccounts branch April 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnstar mtnstar mtnstar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GROUPS: Contactable Daten der Gruppe in Gruppen-API
3 participants
@daniel-illi @mtnstar @kronn