Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname for groups #287

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

TheWalkingLeek
Copy link
Member

Fixes: #272
Currently based on #279

@TheWalkingLeek TheWalkingLeek force-pushed the feature/pbs_272_hostname_for_groups branch from a77859e to def789d Compare August 29, 2023 07:02
@TheWalkingLeek TheWalkingLeek linked an issue Aug 31, 2023 that may be closed by this pull request
6 tasks
@daniel-illi daniel-illi force-pushed the feature/pbs_272_hostname_for_groups branch 4 times, most recently from 79e9113 to 60a31cc Compare September 18, 2023 15:51
@daniel-illi daniel-illi self-requested a review September 18, 2023 15:51
Copy link
Contributor

@daniel-illi daniel-illi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In der Migration wäre es besser, raw sql zu verwenden statt der Models. Falls in Zukunft einmal Models entfernt oder umbenannt werden, geht die Migration kaputt..
  • Ich habe noch eine spec zum Testen des Logos auf der Loginseite hinzugefügt.

Ansonsten LGTM 👍

Base automatically changed from feature/pbs_271_new_root_group to feature/silverscouts October 20, 2023 09:53
@daniel-illi daniel-illi force-pushed the feature/pbs_272_hostname_for_groups branch from 60a31cc to 87aee3a Compare October 20, 2023 09:58
@daniel-illi daniel-illi merged commit 77114cf into feature/silverscouts Oct 20, 2023
1 of 3 checks passed
@daniel-illi daniel-illi deleted the feature/pbs_272_hostname_for_groups branch October 20, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silverscouts: Domains auf bestimmte Gruppen zeigen lassen
2 participants