Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement alumni invitation/reminder emails #291

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Implement alumni invitation/reminder emails #291

merged 15 commits into from
Oct 24, 2023

Conversation

daniel-illi
Copy link
Contributor

@daniel-illi daniel-illi commented Sep 23, 2023 •
edited

Fixes: #273

Blocked by: #278, #279

@daniel-illi daniel-illi force-pushed the feature/pbs_273-silverscouts-optin branch 2 times, most recently from ddccb85 to 878401a Compare September 25, 2023 14:23
@daniel-illi daniel-illi mentioned this pull request Sep 25, 2023
Closed
28 tasks
@daniel-illi
Copy link
Contributor Author

Rubocop schlägt fehl mit dieser Fehlermeldung:

Offenses:

app/domain/alumni/reminders.rb:10:3: E: Lint/Syntax: class definition in method body
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
  class Reminders < Invitations
  ^^^^^
app/domain/alumni/reminders.rb:14:7: E: Lint/Syntax: unexpected token tDOT2
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
      ..parse_duration(:alumni, :reminder, :role_deleted_before_ago).ago
      ^^

Lokal kann ich das nicht reproduzieren. Help?

@daniel-illi daniel-illi force-pushed the feature/pbs_273-silverscouts-optin branch from 75c3d2f to e54a474 Compare October 20, 2023 09:59
@daniel-illi daniel-illi changed the base branch from master to feature/silverscouts October 20, 2023 10:01
TheWalkingLeek
TheWalkingLeek approved these changes Oct 20, 2023
View reviewed changes
app/domain/alumni/applicable_groups.rb
end

def ex_members_groups
ancestor_layers = role.group.layer_group.self_and_ancestors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Könnte sein dass es hier noch einen Nilcheck braucht..
Wenn die Rolle in einer Gruppe war die gelöscht oder fusioniert wurde

db/migrate/20230918160847_add_alumni_processing_timestamps_to_role.rb Show resolved Hide resolved
app/domain/alumni/applicable_groups.rb Outdated Show resolved Hide resolved
@TheWalkingLeek TheWalkingLeek merged commit 296b70c into feature/silverscouts Oct 24, 2023
5 checks passed
@TheWalkingLeek TheWalkingLeek deleted the feature/pbs_273-silverscouts-optin branch October 24, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheWalkingLeek TheWalkingLeek TheWalkingLeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silverscouts: Automatismus / Opt-in
2 participants
@daniel-illi @TheWalkingLeek