add additional states (#583)

this is missing the special return text for the buttons.
It might be confusing for the user at this state

app/models/concerns/events/courses/state.rb

@@ -16,11 +16,10 @@ module Events::Courses::State
         application_open: [:application_paused, :created, :canceled],
         application_paused: [:application_open],
         application_closed: [:assignment_closed, :canceled],
-        assignment_closed: [:ready, :canceled],
-        ready: [:closed, :canceled],
+        assignment_closed: [:ready, :application_closed, :canceled],
+        ready: [:closed, :assignment_closed, :canceled],
         canceled: [:application_open],
-        closed: [:ready]
-      }.freeze
+        closed: [:ready] }.freeze
 
     self.possible_states = SAC_COURSE_STATES.keys.collect(&:to_s)
 

spec/models/event/course_spec.rb

@@ -263,12 +263,12 @@
 
     it 'lists available states for state :assignment_closed' do
       expect(course).to receive(:state).and_return(:assignment_closed)
-      expect(course.available_states).to eq([:ready, :canceled])
+      expect(course.available_states).to eq([:ready, :application_closed, :canceled])
     end
 
     it 'lists available states for state :ready' do
       expect(course).to receive(:state).and_return(:ready)
-      expect(course.available_states).to eq([:closed, :canceled])
+      expect(course.available_states).to eq([:closed, :assignment_closed, :canceled])
     end
 
     it 'lists available states for state :canceled' do