Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display member number in search results #514

Merged
merged 5 commits into from
May 3, 2024

Conversation

carlobeltrame
Copy link
Member

Fixes #476

@carlobeltrame carlobeltrame marked this pull request as ready for review May 2, 2024 13:45
Copy link
Member

@TheWalkingLeek TheWalkingLeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es macht denke ich mehr Sinn das ganze zumindest visuell unter membership_number zu implementieren oder?
Das ist ja schlicht ein alias_attribute auf der Person. Dann ist es auch unter demselben Spaltennamen ersichtlich wie auf der person#show Seite

@TheWalkingLeek
Copy link
Member

Ansonsten hab ichs durchgetestet und schaut gut aus, also anschliessend gerne mergen :)

@carlobeltrame carlobeltrame force-pushed the display-member-number-in-search-results branch 2 times, most recently from 838b0d8 to a0d4946 Compare May 3, 2024 11:26
@carlobeltrame carlobeltrame force-pushed the display-member-number-in-search-results branch from a0d4946 to a7c985a Compare May 3, 2024 13:02
@carlobeltrame carlobeltrame merged commit 4e5290e into master May 3, 2024
3 of 5 checks passed
@carlobeltrame carlobeltrame deleted the display-member-number-in-search-results branch May 3, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEOPLE: Globale Suche nach Mitgliedernummer
2 participants