Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVENTS: Email before qualification expires #617

Merged
merged 8 commits into from
Jun 26, 2024
Merged

EVENTS: Email before qualification expires #617

merged 8 commits into from
Jun 26, 2024

Conversation

hunchr
Copy link
Contributor

@hunchr hunchr commented Jun 11, 2024 •
edited
Loading

Fixes #260

@hunchr hunchr self-assigned this Jun 11, 2024
@daniel-illi daniel-illi force-pushed the master branch 2 times, most recently from a477c7c to 875e250 Compare June 12, 2024 12:09
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch 5 times, most recently from 66a7f18 to 0b16da6 Compare June 17, 2024 12:25
@hunchr hunchr changed the title Email before qualification expires EVENTS: Email before qualification expires Jun 17, 2024
@hunchr hunchr requested a review from mtnstar June 18, 2024 06:43
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch from 0b16da6 to f6c376c Compare June 18, 2024 06:43
@hunchr hunchr marked this pull request as ready for review June 18, 2024 06:43
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch 2 times, most recently from 8daf5c6 to 21e33d1 Compare June 19, 2024 11:18
mtnstar
mtnstar requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das sieht schon super aus 🥳

prüfe mal die Kommentare

app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
spec/jobs/qualification/expiration_mailer_job_spec.rb Outdated Show resolved Hide resolved
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch from 2f2ef66 to ad06b3a Compare June 19, 2024 12:53
@hunchr hunchr requested a review from mtnstar June 19, 2024 13:04
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch from ad06b3a to c9c5d01 Compare June 20, 2024 08:00
mtnstar
mtnstar requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast fertig 🥳 ... schau dir mal die Kommentare an

app/domain/qualification/expiration.rb Outdated Show resolved Hide resolved
app/domain/qualification/expiration.rb Outdated Show resolved Hide resolved
app/domain/qualification/expiration.rb Outdated Show resolved Hide resolved
app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
spec/jobs/qualification/expiration_mailer_job_spec.rb Outdated Show resolved Hide resolved
spec/jobs/qualification/expiration_mailer_job_spec.rb Outdated Show resolved Hide resolved
@hunchr hunchr requested a review from mtnstar June 24, 2024 09:58
mtnstar
mtnstar requested changes Jun 24, 2024
View reviewed changes
app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
app/mailers/qualification/expiration_mailer.rb Outdated Show resolved Hide resolved
spec/jobs/qualification/expiration_mailer_job_spec.rb Outdated Show resolved Hide resolved
@hunchr hunchr requested a review from mtnstar June 24, 2024 12:30
mtnstar
mtnstar requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

langsam wirds perfekt ... lueg mau na ds feedback a

app/jobs/qualification/expiration_mailer_job.rb Outdated Show resolved Hide resolved
app/mailers/qualification/expiration_mailer.rb Outdated Show resolved Hide resolved
app/mailers/qualification/expiration_mailer.rb Outdated Show resolved Hide resolved
spec/jobs/qualification/expiration_mailer_job_spec.rb Outdated Show resolved Hide resolved
@hunchr hunchr requested a review from mtnstar June 25, 2024 12:56
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch from 72f110c to 2f048ba Compare June 26, 2024 07:32
@hunchr hunchr force-pushed the feature/260-email-before-qualification-expires branch from 0a75de3 to 0f8664f Compare June 26, 2024 12:46
@mtnstar mtnstar merged commit 9eac6c0 into master Jun 26, 2024
9 checks passed
@mtnstar mtnstar deleted the feature/260-email-before-qualification-expires branch June 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnstar mtnstar Awaiting requested review from mtnstar

Assignees

@hunchr hunchr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVENTS: E-Mails bevor Qualifikation abläuft
2 participants
@hunchr @mtnstar