Override sorting_name to ignore SAC/CAS prefix in Sektion for hitobito#2673 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
force-pushed
the
feature/2673-sort-group-names-remove-prefix
branch
from
b77aedf
to
59e1cd8
Compare
rnestler
commented
Jun 12, 2024
app/models/group/sektion.rb
Outdated
| private | ||
|
|
||
| def name_prefix | ||
| language == 'DE' ? 'SAC' : 'CAS' |
There was a problem hiding this comment.
We could also just always remove both prefixes.
rnestler
force-pushed
the
feature/2673-sort-group-names-remove-prefix
branch
from
59e1cd8
to
50010bd
Compare
rnestler
commented
Jun 17, 2024
Comment on lines
-13
to
-15
| def sub_layers | ||
| super.reorder(Arel.sql(NAME_WITHOUT_PREFIX)) | ||
| end |
There was a problem hiding this comment.
This was added in #529, but didn't work properly.
This avoids the broken SQL query modification
rnestler
force-pushed
the
feature/2673-sort-group-names-remove-prefix
branch
from
50010bd
to
ea753c0
Compare
6 tasks
Largo
reviewed
Jun 17, 2024
There was a problem hiding this comment.
nice! 🚀
- we changed display_name.delete_prefix('SAC ').delete_prefix('CAS ') to include a space.
fixes GROUPS: Sortierung Groups mit static_name hitobito#2673
Largo
changed the title
Largo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the broken SQL query modification.
Ref: #2673
Depends on hitobito/hitobito#2677