Admins shall manage the festival participation from now

app/models/group/verein.rb

@@ -1,4 +1,4 @@
-#  Copyright (c) 2012-2019, Schweizer Blasmusikverband. This file is part of
+#  Copyright (c) 2012-2020, Schweizer Blasmusikverband. This file is part of
 #  hitobito_sbv and licensed under the Affero General Public License version 3
 #  or later. See the COPYING file at the top-level directory or at
 #  https://github.com/hitobito/hitobito_sbv.
@@ -104,7 +104,7 @@ def suisa_admins
   ### ROLES
 
   class Admin < Role::Admin
-    self.permissions = [:layer_and_below_full]
+    self.permissions = [:layer_and_below_full, :festival_participation]
   end
 
   class Conductor < Role

app/models/role/vorstand_praesident.rb

@@ -1,4 +1,4 @@
-#  Copyright (c) 2012-2019, Schweizer Blasmusikverband. This file is part of
+#  Copyright (c) 2012-2020, Schweizer Blasmusikverband. This file is part of
 #  hitobito_sbv and licensed under the Affero General Public License version 3
 #  or later. See the COPYING file at the top-level directory or at
 #  https://github.com/hitobito/hitobito_sbv.
@@ -18,5 +18,5 @@
 #
 
 class Role::VorstandPraesident < Role
-  self.permissions = [:layer_full, :layer_and_below_read, :contact_data, :festival_participation]
+  self.permissions = [:layer_full, :layer_and_below_read, :contact_data]
 end

spec/abilities/group_ability_spec.rb

@@ -17,17 +17,17 @@
   end
 
   describe 'manage application to festivals' do
-    context 'as president of a group' do
-      let(:group_role_class) { Group::VereinVorstand::Praesident }
-      let(:group) { groups(:vorstand_mg_aarberg)}
+    context 'as admin of a group' do
+      let(:group_role_class) { Group::Verein::Admin }
+      let(:group) { groups(:musikgesellschaft_aarberg) }
       let(:checked_group) { groups(:musikgesellschaft_aarberg) }
 
       it { is_expected.to be_able_to(:manage_festival_application, checked_group)}
     end
 
-    context 'as president of a group' do
-      let(:group_role_class) { Group::VereinVorstand::Praesident }
-      let(:group) { groups(:vorstand_mg_aarberg)}
+    context 'as admin of a group' do
+      let(:group_role_class) { Group::Verein::Admin }
+      let(:group) { groups(:musikgesellschaft_aarberg) }
       let(:checked_group) { groups(:musikgesellschaft_aarberg) }
 
       it { is_expected.to be_able_to(:manage_festival_application, checked_group)}
@@ -41,9 +41,17 @@
       it { is_expected.to_not be_able_to(:manage_festival_application, checked_group)}
     end
 
-    context 'as president of a different group' do
+    context 'as president of a group' do
       let(:group_role_class) { Group::VereinVorstand::Praesident }
-      let(:group) { groups(:vorstand_mg_alterswil)}
+      let(:group) { groups(:vorstand_mg_aarberg) }
+      let(:checked_group) { groups(:musikgesellschaft_aarberg) }
+
+      it { is_expected.to_not be_able_to(:manage_festival_application, checked_group)}
+    end
+
+    context 'as admin of a different group' do
+      let(:group_role_class) { Group::Verein::Admin }
+      let(:group) { groups(:musikgesellschaft_alterswil)}
       let(:checked_group) { groups(:musikgesellschaft_aarberg) }
 
       it { is_expected.to_not be_able_to(:manage_festival_application, checked_group)}