Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dict support on metadata, optimize datetime format judgment rules, add eq for combiner #135

Merged
merged 21 commits into from
Feb 7, 2024

Conversation

MooooCat
Copy link
Contributor

@MooooCat MooooCat commented Feb 5, 2024

Description

This PR mainly completes:

  • Add dict support on metadata, for datetime inspector, the datetime_format returned by the update method can be passed in in list form;
  • Optimize datetime format judgment rules, which increases robustness and reduces misjudgments in the face of missing data and incorrect data.

How has this been tested?

The content of this modification has been covered by test cases.

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat MooooCat changed the title Add dict support on metadata, optimize datetime format judgment rules Add dict support on metadata, optimize datetime format judgment rules, add eq for combiner Feb 5, 2024
@MooooCat MooooCat marked this pull request as ready for review February 5, 2024 10:09
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (782bcfe) 80.26% compared to head (4dfe87a) 80.38%.

❗ Current head 4dfe87a differs from pull request most recent head 63d19f7. Consider uploading reports for the commit 63d19f7 to get more accurate results

Files Patch % Lines
sdgx/data_models/metadata.py 88.88% 2 Missing ⚠️
sdgx/data_models/combiner.py 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   80.26%   80.38%   +0.11%     
==========================================
  Files          66       66              
  Lines        2975     3008      +33     
==========================================
+ Hits         2388     2418      +30     
- Misses        587      590       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdgx/data_models/inspectors/datetime.py Outdated Show resolved Hide resolved
@MooooCat
Copy link
Contributor Author

MooooCat commented Feb 7, 2024

I had a breakfast before fix the code, I found that @Wh1isper had already correct them when I push commits.

hhhhhh, happy new year!

@MooooCat MooooCat merged commit 775e605 into main Feb 7, 2024
11 checks passed
@Wh1isper Wh1isper deleted the feature-metadata-dict-support branch February 7, 2024 01:26
@Wh1isper
Copy link
Collaborator

Wh1isper commented Feb 7, 2024

Happy new year~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants