Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cov and docker images #46

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add test cov and docker images #46

merged 3 commits into from
Nov 22, 2023

Conversation

wunder957
Copy link
Contributor

Description

  • Add pytest-cov
  • Add Pre-build docker image

Motivation and Context

  • Support build latest docker image when main been pushed
  • Add Test coverage in CI

How has this been tested?

See actions

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

sweep-ai bot commented Nov 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@wunder957 wunder957 marked this pull request as ready for review November 16, 2023 13:58
@wunder957 wunder957 added the enhancement New feature or request label Nov 16, 2023
@wunder957 wunder957 assigned wunder957 and unassigned MooooCat Nov 16, 2023
@wunder957
Copy link
Contributor Author

@MooooCat Currently this repository does not have dockerhub users and tokens configured, I will merge this as soon as it is ready

@wunder957 wunder957 merged commit 5e4e071 into main Nov 22, 2023
7 checks passed
@wunder957 wunder957 deleted the feature-ci branch November 22, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants