Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subdir for NDArrayLoader to prevent collision of cache files #78

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Add subdir for NDArrayLoader to prevent collision of cache files #78

merged 3 commits into from
Dec 19, 2023

Conversation

Wh1isper
Copy link
Collaborator

@Wh1isper Wh1isper commented Dec 19, 2023 •
edited
Loading

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 19, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

MooooCat
MooooCat approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@MooooCat MooooCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sub dir can prevent collision problem

@Wh1isper Wh1isper merged commit 788284a into main Dec 19, 2023
11 checks passed
@Wh1isper Wh1isper deleted the feature-ndarry-loader-configuable branch December 19, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooooCat MooooCat MooooCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wh1isper @MooooCat