Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fun facts, mostly related to sales #13

Merged
merged 1 commit into from
Dec 26, 2017

Conversation

@Thunderforge Thunderforge changed the title Adding fun facts Adding fun facts, mostly related to sales Dec 26, 2017
@hiulit hiulit merged commit 38bf033 into hiulit:master Dec 26, 2017
@hiulit
Copy link
Owner

hiulit commented Dec 26, 2017

Thanks a lot for the new Fun Facts! 😃 🎉

@hiulit
Copy link
Owner

hiulit commented Dec 27, 2017

Btw, if you don't mind, I'd like to ask you a couple of questions:

  • Do you find Fun Facts! Splashscreens useful? Are you using it?
  • If so, did you install it via this repository or RetroPie-Extra?
  • Did you find the instructions easy to follow? Are they readable/understandable?
  • What would like to see improved, if anything?

Thanks!

@Thunderforge
Copy link
Contributor Author

Thunderforge commented Jan 3, 2018

Do you find Fun Facts! Splashscreens useful? Are you using it?

I just started using RetroPie and have been experimenting with splashscreens. This was one that I ran across. So far, I have not installed it.

If so, did you install it via this repository or RetroPie-Extra?

I did not install it yet, but if I did, I would do it from RetroPie-Extras due to the one-step setup.

Did you find the instructions easy to follow? Are they readable/understandable?

The instructions for adding facts was simple enough. I found the instructions to generate splashscreens to be difficult to follow, which is why installing it from RetroPie-Extras was desirable.

What would like to see improved, if anything?

I think there needs to be some standardization on the writing style of the facts. There are a number of issues that I saw:

  • The facts differ wildly in length, which may make screens look inconsistent.
    • Extremely short: Devil May Cry started out as a failed Resident Evil game.
    • Extremely long: In the 1980s, a service called Gameline allowed users to download games to the Atari 2600 over regular phone lines. It was not a success, but did form part of the foundation for America Online, the world's largest Internet service provider.
  • Game names are inconsistently handled. Some are just plain (e.g Ice Climber was the first game…, some are in single quotes (e.g. The highest grossing game of all time so far is 'World of Warcraft')
  • Pokémon is misspelled as "Pokemon" throughout.
  • There is inconsistent tone, especially with some facts having a pithy comment at the end.
    • Neutral tone: The first game to feature true background music was Namco's Rally-X in 1980.
    • Casual tone: Half-Life 2: Episode 2 features a hidden room inspired by the television show "Lost". Desmond, push the button!
    • Incredulous tone: The Magnavox Odyssey, released in 1972, contained 40 transistors and no microprocessor. The Pentium 4 microprocessor contains 42 million transistors on the chip itself!

I would recommend having some guidelines like the following (I'm just making these up on the fly):

  • Fun facts must be between 50-300 characters long.
  • The tone should be neutral (even if you find it surprising)
  • The name of the game should match that found on Wikipedia (this includes Pokémon, not "Pokemon")
  • Surround game names with single quotes (it would be great if we could somehow italicize them when displayed in the screenshots)

Also, I think it would be good to require sources in PRs, that way we don't have any urban legends sneak in (e.g. By exploiting a glitch, you can earn the Triforce in 'The Legend of Zelda: Ocarina of Time').

@Thunderforge Thunderforge deleted the patch-1 branch January 5, 2018 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants