Toggle space mode with shift-space

This should fix chewing#141
hiunnhue · Apr 4, 2014 · 203b861 · 203b861
1 parent b7fbb78
commit 203b861
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/chewingio.c b/src/chewingio.c
@@ -1727,6 +1727,9 @@ CHEWING_API int chewing_handle_ShiftSpace(ChewingContext *ctx)
     if (!pgdata->bSelect) {
         CheckAndResetRange(pgdata);
     }
+
+    chewing_set_ShapeMode(ctx, 1 - chewing_get_ShapeMode(ctx));
+
     CallPhrasing(pgdata, 0);
     MakeOutputWithRtn(pgo, pgdata, keystrokeRtn);
     return 0;

diff --git a/test/test-bopomofo.c b/test/test-bopomofo.c
@@ -1015,7 +1015,27 @@ void test_PageDown()
 
 void test_ShiftSpace()
 {
-    /* FIXME: Implement this. */
+    ChewingContext *ctx;
+    int mode;
+
+    ctx = chewing_new();
+    start_testcase(ctx, fd);
+
+    mode = chewing_get_ShapeMode(ctx);
+    ok(mode == HALFSHAPE_MODE, "mode shall be HALFSHAPE_MODE");
+
+    type_keystroke_by_string(ctx, "<SS>");
+    mode = chewing_get_ShapeMode(ctx);
+    ok(mode == FULLSHAPE_MODE, "mode shall be FULLSHAPE_MODE");
+
+    type_keystroke_by_string(ctx, " ");
+    ok_commit_buffer(ctx, "\xE3\x80\x80"); /* Fullshape Space (U+3000) */
+
+    chewing_set_ChiEngMode(ctx, SYMBOL_MODE);
+    type_keystroke_by_string(ctx, "a");
+    ok_commit_buffer(ctx, "\xEF\xBD\x81"); /* Fullshape a */
+
+    chewing_delete(ctx);
 }
 
 void test_Numlock_numeric_input()