Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api To Get Block Given Hive Block Number #28

Merged
merged 2 commits into from
May 24, 2023

Conversation

Rishi556
Copy link
Contributor

@Rishi556 Rishi556 commented May 1, 2023

Creates a method to get a engine block given a hive block number(or nothing if one doesn't exist for that particular hive block).

Copy link
Contributor

@bt-cryptomancer bt-cryptomancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of this new API call is a bit misleading. getHiveBlockInfo sounds like we're getting information about a Hive block. Can we call it getBlockInfoByHiveBlock instead? Or maybe getBlockInfoByHB to be a little less wordy?

@Rishi556
Copy link
Contributor Author

I named it getBlockInfoByHiveBlock since none of the other calls have abbreviations and I didn't want to change that style.

Copy link
Contributor

@bt-cryptomancer bt-cryptomancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will include in the next release.

@bt-cryptomancer bt-cryptomancer merged commit 2304505 into hive-engine:qa May 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants