-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ClusterRole from Helm chart with dependent Role to allow Pod annotation updates when the operator is not running #240
Conversation
3e7b17c
to
adf0a88
Compare
adf0a88
to
f0fb856
Compare
5bc9a18
to
c28ef2c
Compare
a2aaf54
to
77567fa
Compare
c28ef2c
to
d45bfa1
Compare
832817d
to
4f5be70
Compare
4ace0ae
to
3559f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
FYI: Probably there is nothing we want to change there, but in the NOTES.txt we display a warning when the |
d45bfa1
to
b9059fa
Compare
75a725a
to
50a6568
Compare
e618bd7
to
32382b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more text suggestions. Otherwise approved.
32382b7
to
2666046
Compare
b9059fa
to
72f30b4
Compare
2666046
to
43973e5
Compare
5dcc2a4
to
8efd9ca
Compare
…annotation updates when the operator is not running
…t, Role and RoleBinding
43973e5
to
30edb5a
Compare
https://hivemq.kanbanize.com/ctrl_board/22/cards/22118/details/