Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ClusterRole from Helm chart with dependent Role to allow Pod annotation updates when the operator is not running #240

Conversation

Donnerbart
Copy link
Contributor

@Donnerbart Donnerbart self-assigned this May 15, 2024
@cla-bot cla-bot bot added the cla-signed label May 15, 2024
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch 3 times, most recently from 3e7b17c to adf0a88 Compare May 21, 2024 10:25
@Donnerbart Donnerbart changed the base branch from master to epic/platform-operator-1.4.0 May 21, 2024 10:31
@Donnerbart Donnerbart marked this pull request as ready for review May 21, 2024 11:37
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch from adf0a88 to f0fb856 Compare May 22, 2024 11:45
@Donnerbart Donnerbart force-pushed the epic/platform-operator-1.4.0 branch from 5bc9a18 to c28ef2c Compare May 24, 2024 12:57
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch 6 times, most recently from a2aaf54 to 77567fa Compare May 24, 2024 15:51
@Donnerbart Donnerbart force-pushed the epic/platform-operator-1.4.0 branch from c28ef2c to d45bfa1 Compare May 24, 2024 16:11
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch 4 times, most recently from 832817d to 4f5be70 Compare May 24, 2024 17:30
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch 2 times, most recently from 4ace0ae to 3559f82 Compare May 24, 2024 17:41
Copy link
Contributor

@afalhambra-hivemq afalhambra-hivemq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afalhambra-hivemq
Copy link
Contributor

FYI: Probably there is nothing we want to change there, but in the NOTES.txt we display a warning when the serviceAccount is created externally. Not sure, if you want to add something else to it, or is it fine as is right now.
Just a small heads-up

@Donnerbart Donnerbart force-pushed the epic/platform-operator-1.4.0 branch from d45bfa1 to b9059fa Compare May 27, 2024 12:53
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch from 75a725a to 50a6568 Compare May 27, 2024 12:53
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Show resolved Hide resolved
charts/hivemq-platform-operator/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/templates/NOTES.txt Outdated Show resolved Hide resolved
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch 2 times, most recently from e618bd7 to 32382b7 Compare May 28, 2024 11:44
Copy link
Contributor

@mhofsche mhofsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more text suggestions. Otherwise approved.

charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch from 32382b7 to 2666046 Compare May 28, 2024 14:57
@Donnerbart Donnerbart force-pushed the epic/platform-operator-1.4.0 branch from b9059fa to 72f30b4 Compare May 28, 2024 14:59
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch from 2666046 to 43973e5 Compare May 28, 2024 14:59
@Donnerbart Donnerbart force-pushed the epic/platform-operator-1.4.0 branch from 5dcc2a4 to 8efd9ca Compare May 29, 2024 09:57
@Donnerbart Donnerbart force-pushed the bugfix/22118-fix-missing-pod-permission branch from 43973e5 to 30edb5a Compare May 29, 2024 10:03
@Donnerbart Donnerbart merged commit eaedf9b into epic/platform-operator-1.4.0 May 29, 2024
20 checks passed
@Donnerbart Donnerbart deleted the bugfix/22118-fix-missing-pod-permission branch May 29, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants