Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct CONNACKv5 reason code BAD_USERNAME_OR_PASSWORD #120

Conversation

michaelg9
Copy link
Contributor

@michaelg9 michaelg9 commented Nov 29, 2019

Addresses issue #119

Motivation

Resolves #119

Changes
Add correct reason code enum for BAD_USER_NAME_OR_PASSWORD
There is no test file for this class

@cla-bot
Copy link

cla-bot bot commented Nov 29, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @michaelg9 on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@michaelg9
Copy link
Contributor Author

Just sent the signed contributor agreement

@MagiErber
Copy link
Member

Hi @michaelg9,
thank you for your contribution. We received your CLA, so the @cla-bot check can run again.
Best regards,
Magi

@cla-bot cla-bot bot added the cla-signed label Nov 29, 2019
@cla-bot
Copy link

cla-bot bot commented Nov 29, 2019

The cla-bot has been summoned, and re-checked this pull request!

@SgtSilvio SgtSilvio merged commit dfbfb87 into hivemq:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Connack Reason code for Bad username or password
3 participants