Feature/enhanced authentication #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtSilvio
force-pushed
the
feature/enhanced-authentication
branch
3 times, most recently
from
a35e47a
to
88c0766
Compare
SgtSilvio
force-pushed
the
feature/enhanced-authentication
branch
from
3753b0b
to
8ff164c
Compare
SgtSilvio
changed the title
SgtSilvio
force-pushed
the
feature/enhanced-authentication
branch
from
17cb7a9
to
bbd8e16
Compare
Improved channel pipeline, removed/combined unnecessary handlers
ConnectHandler now always calls AuthenticatorService Simplified Authenticators
Made fail reason string optional
Added missing failAuthentication(reasonCode) method Improved async methods and javadoc Made fail reason string optional
Added check if reason code can be sent by the server in AuthOutput
Improved authentication reason strings and event logs Improved triggering life cycle events Improved sending connack and disconnect Improved reason code mapping Improved async outputs, extension tasks, ...
SgtSilvio
force-pushed
the
feature/enhanced-authentication
branch
from
934ca7a
to
9f7637d
Compare
LBrandl
approved these changes
Jan 30, 2020
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Exposing an enhanced authentication API in the extension SDK to be able to implement challenge/response style authentication and re-authentication.
Resolves #110
Resolves #56
Resolves #72
Changes
Extensions are now able to handle AUTH packets and re-authentication.