Bugfix for qos change in extension affecting the publisher #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffecting publisher
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Remit on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
src/main/java/com/hivemq/mqtt/message/publish/PUBLISHFactory.java
Outdated
Show resolved
Hide resolved
YannickWeber
approved these changes
Sep 15, 2021
SgtSilvio
approved these changes
Sep 17, 2021
Remit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves a bug when changing QoS in the inbound interceptor also affected publisher so that it got unexpected responses causing the client to disconnect.
Changes
Splitting QoS on the modifiable publish into original QoS used for publishers and modified QoS used for subscribers (onward QoS).