Fix SIGSEGV during shutdown with enabled diagnostics mode #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @hlohse on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
hlohse
force-pushed
the
bugfix/sigsegv-during-shutdown-with-diagnostics
branch
from
51e2f49
to
0043207
Compare
Remit
approved these changes
Oct 5, 2022
This was caused by DiagnosticMode's ConsoleReporter which periodically writes metrics to disk and must not access any RocksDB instance after it has been closed already. Therefore, stop DiagnosticMode and its ConsoleReporter's executore first via ShutdownHooks.
hlohse
force-pushed
the
bugfix/sigsegv-during-shutdown-with-diagnostics
branch
from
0043207
to
ee32524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid crash during shutdown with enabled diagnostics mode.
Changes
This was caused by DiagnosticMode's ConsoleReporter which periodically writes metrics to disk and must not access any RocksDB instance after it has been closed already.
Therefore, stop DiagnosticMode first via ShutdownHooks.
https://hivemq.kanbanize.com/ctrl_board/42/cards/9246/details/