Fix not sending will on clean start during re-connect #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBrandl
approved these changes
Nov 10, 2022
A-Imal
approved these changes
Nov 11, 2022
hlohse
force-pushed
the
bugfix/9739-will-message-on-clean-session-start
branch
from
29b8274
to
61ae8ce
Compare
If a client re-connects with a clean start, the specification defines that this "ends" and existing sessions. Whenever a session ends, the specification defines that the ending session's will must be sent, if available and still pending due to a session expiry interval or a will delay interval that has not been reached yet. This is achieved by sending any still pending will between disconnecting and (re-)connecting. Also improved method names of PendingWillMessages.
Don't rely on the CheckWillsTask and ClientSessionCleanUpTask to be scheduled well enough that there can never be a situation where there is still a will send pending while the session, which contains the will data, has already been cleaned up.
For testing purposes, assert that this never happens because it is unexpected: We must guarantee that a will is sent before the session is gone/cleaned up. To detect unknown race conditions in production, log a warning and don't throw a NullPointerException, as this might block client connections and the sending of other wills.
hlohse
force-pushed
the
bugfix/9739-will-message-on-clean-session-start
branch
from
61ae8ce
to
f9973f2
Compare
Added commit hooks to update will message references whenever a client session is removed or overwritten.
hlohse
force-pushed
the
bugfix/9739-will-message-on-clean-session-start
branch
from
928957d
to
c3a0457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/42/cards/9739/details/
If a client re-connects with a clean start, the specification defines that this "ends" and existing sessions.
Whenever a session ends, the specification defines that the ending session's will must be sent, if available and still pending due to a session expiry interval or a will delay interval that has not been reached yet.
This is achieved by sending any still pending will between disconnecting and (re-)connecting.
Also improved method names of PendingWillMessages.