Reduce BucketLock contention by RemoveEntryTask #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remit
reviewed
Jan 13, 2023
src/main/java/com/hivemq/persistence/payload/RemoveEntryTask.java
Outdated
Show resolved
Hide resolved
Remit
approved these changes
Jan 13, 2023
LBrandl
approved these changes
Jan 16, 2023
hlohse
force-pushed
the
improvement/11291-remove-entry-task-bucket-lock-contention
branch
from
de14e45
to
9de4570
Compare
Added a guard so that concurrently running RemoveEntryTasks don't try to process entries of the shared removablePayloads queue. Since this is more of a workaround, the structure should be improved in the scope of the ticket #11000.
Ticket number is enough.
hlohse
force-pushed
the
improvement/11291-remove-entry-task-bucket-lock-contention
branch
from
9de4570
to
b99abb9
Compare
hlohse
deleted the
improvement/11291-remove-entry-task-bucket-lock-contention
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hivemq.kanbanize.com/ctrl_board/42/cards/11291/details
Added a guard so that concurrently running RemoveEntryTasks don't try to process entries of the shared removablePayloads queue.
Since this is more of a workaround, the structure should be improved in the scope of the ticket hivemq.kanbanize.com/ctrl_board/42/cards/11000/details.