Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log IOExceptions while disconnecting #374

Merged
merged 1 commit into from Feb 24, 2020
Merged

Do not log IOExceptions while disconnecting #374

merged 1 commit into from Feb 24, 2020

Conversation

SgtSilvio
Copy link
Member

Motivation
Resolves #373

Changes

  • Do not log IOExceptions while disconnecting
  • Log other exceptions on warn level, not error

@cla-bot cla-bot bot added the cla-signed label Feb 21, 2020
@SgtSilvio SgtSilvio added this to In progress in Version 1.1.x via automation Feb 21, 2020
@SgtSilvio SgtSilvio moved this from In progress to Review in progress in Version 1.1.x Feb 21, 2020
@SgtSilvio SgtSilvio added this to the 1.1.4 milestone Feb 21, 2020
@SgtSilvio SgtSilvio self-assigned this Feb 21, 2020
Version 1.1.x automation moved this from Review in progress to Reviewer approved Feb 23, 2020
@SgtSilvio SgtSilvio merged commit 046970b into develop Feb 24, 2020
Version 1.1.x automation moved this from Reviewer approved to Done Feb 24, 2020
@SgtSilvio SgtSilvio deleted the improvement/disconnect-ioexception-logging branch February 24, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitseti gitseti gitseti approved these changes

Assignees

@SgtSilvio SgtSilvio

Labels
cla-signed improvement
Projects
No open projects
Version 1.1.x
  
Done
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.

Error logged when server closes connection on disconnect
2 participants
@SgtSilvio @gitseti