Skip to content

Commit

Permalink
Removal of base exception handling
Browse files Browse the repository at this point in the history
  • Loading branch information
joamag committed Mar 8, 2019
1 parent fe71d21 commit a3b8655
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/appier_extras/parts/admin/part.py
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ def oauth_authorize(self):
# asserts that the requested scope is valid for the associated
# OAuth client meaning that they overlap
oauth_client.assert_scope(scope_l)
except BaseException as exception:
except Exception as exception:
redirect_uri = self.field("redirect_uri", None)
state = self.field("state", None)
if not redirect_uri: raise
Expand Down
2 changes: 1 addition & 1 deletion src/appier_extras/parts/contentful/partials/_contentful.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def _contentful_value(
*args,
**kwargs
) or dict()
except BaseException as exception:
except Exception as exception:
self.logger.warning("Problem while accessing Contentful: %s" % exception)
return default

Expand Down
2 changes: 1 addition & 1 deletion src/appier_extras/parts/diag/part.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def after_request(self):
if self.store: self._store_log()
if self.loggly: self._loggly_log()
if self.logstash: self._logstash_log()
except BaseException as exception:
except Exception as exception:
self.owner.log_error(
exception,
message = "Problem running diag logging: %s"
Expand Down
4 changes: 2 additions & 2 deletions src/appier_extras/parts/prismic/partials/_prismic.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def _prismic_objects(
*args,
**kwargs
) or []
except BaseException as exception:
except Exception as exception:
self.logger.warning("Problem while accessing prismic: %s" % exception)
return default

Expand Down Expand Up @@ -361,7 +361,7 @@ def _prismic_value(
*args,
**kwargs
) or []
except BaseException as exception:
except Exception as exception:
self.logger.warning("Problem while accessing prismic: %s" % exception)
return default

Expand Down

0 comments on commit a3b8655

Please sign in to comment.