Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev tsilva confirm account #17

Merged
merged 7 commits into from Jun 7, 2016
Merged

Dev tsilva confirm account #17

merged 7 commits into from Jun 7, 2016

Conversation

tsilva
Copy link
Contributor

@tsilva tsilva commented Jun 7, 2016

No description provided.

@tsilva tsilva added enhancement New feature or request triage Issue currently under triage p-medium Medium priority issue labels Jun 7, 2016
tsilva
tsilva reviewed Jun 7, 2016
View reviewed changes
src/budy/models/account.py
@@ -182,7 +182,10 @@ def set_store_s(self, store):
@appier.operation(name = "Notify")
def notify(self, name = None):
name = name or "account.new"
account = self.reload(map = True)
account = self.reload(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rules is True to be able to access the confirmation token, otherwise I won't be able to create the confirmation url

@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited

Coverage Status

Coverage increased (+0.05%) to 70.756% when pulling 2c4ebae on dev_tsilva_confirm_account into c172c2c on master.

@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 70.588% when pulling fee1d3a on dev_tsilva_confirm_account into c172c2c on master.

@joamag joamag merged commit 169b8e7 into master Jun 7, 2016
@joamag joamag deleted the dev_tsilva_confirm_account branch June 7, 2016 11:52
@coveralls
Copy link

coveralls commented Jun 7, 2016 •
edited

Coverage Status

Coverage increased (+0.01%) to 70.715% when pulling fee1d3a on dev_tsilva_confirm_account into c172c2c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joamag joamag

Labels
enhancement New feature or request p-medium Medium priority issue triage Issue currently under triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsilva @coveralls @joamag