Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added order lines csv #20

Merged
merged 5 commits into from
Jun 9, 2016
Merged

Added order lines csv #20

merged 5 commits into from
Jun 9, 2016

Conversation

acaldas
Copy link

@acaldas acaldas commented Jun 8, 2016

No description provided.

@acaldas acaldas added enhancement New feature or request triage Issue currently under triage p-medium Medium priority issue labels Jun 8, 2016
@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 70.781% when pulling 74d2b82 on dev_acaldas_order_csv into c32442f on master.

@tsilva tsilva assigned joamag and unassigned tsilva Jun 8, 2016
tsilva
tsilva reviewed Jun 8, 2016
View reviewed changes
src/budy/controllers/api/order.py
"country"
)]
for line in order.lines:
if not line.product: continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joamag not sure if lines without products should be ignored or included

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsilva products should be considered mandatory for a line

Copy link
Contributor

@joamag joamag Jun 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsilva include also line.product.product_id and remove line.country

@coveralls
Copy link

coveralls commented Jun 8, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 70.746% when pulling d60059f on dev_acaldas_order_csv into c32442f on master.

@joamag
Copy link
Contributor

joamag commented Jun 9, 2016 •
edited
Loading

@acaldas @tsilva also include information about the order (eg: order id, date, account, order_total, etc) just like the normal order export. and don't call total to the line total, instead use something like (line_total)

@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 70.86% when pulling 34ad2f5 on dev_acaldas_order_csv into c32442f on master.

@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 70.621% when pulling 68ab57d on dev_acaldas_order_csv into e58d94e on master.

@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 70.621% when pulling 68ab57d on dev_acaldas_order_csv into e58d94e on master.

@joamag joamag merged commit 968dee3 into master Jun 9, 2016
@joamag joamag deleted the dev_acaldas_order_csv branch June 9, 2016 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joamag joamag

Labels
enhancement New feature or request p-medium Medium priority issue triage Issue currently under triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acaldas @coveralls @joamag @tsilva