Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Logstash Handler #11

Merged
merged 12 commits into from Dec 14, 2023
Merged

add Logstash Handler #11

merged 12 commits into from Dec 14, 2023

Conversation

hugo-gomes
Copy link
Member

@hugo-gomes hugo-gomes commented Dec 12, 2023 •
edited

@joamag
Copy link
Contributor

joamag commented Dec 12, 2023

  • Add a changelog reference
  • Run some unit testing of this handler with some mocking - test flush operation

@joamag joamag assigned hugo-gomes and unassigned joamag Dec 12, 2023
@hugo-gomes hugo-gomes assigned joamag and unassigned hugo-gomes Dec 12, 2023
@joamag
chore: improved solution designed
41a76f3 
Removed appier dependency.
joamag
joamag requested changes Dec 13, 2023
View reviewed changes
src/colony/base/loggers.py Outdated Show resolved Hide resolved
@joamag joamag assigned hugo-gomes and unassigned joamag Dec 13, 2023
@joamag
chore: improved unit tests
2d26996 
Added formatted message testing.
@joamag joamag added enhancement New feature or request p-medium Medium priority issue labels Dec 13, 2023
@hugo-gomes hugo-gomes assigned joamag and unassigned hugo-gomes Dec 13, 2023
@joamag joamag merged commit 19ca3a0 into master Dec 14, 2023
11 of 13 checks passed
@joamag joamag deleted the logstash branch December 14, 2023 12:24
@hugo-gomes hugo-gomes mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamag joamag joamag approved these changes

Assignees

@joamag joamag

Labels
enhancement New feature or request p-medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugo-gomes @joamag