feat: safer check for integer in Excel

hivesolutions · Feb 4, 2022 · 738167a · 738167a
1 parent 410a983
commit 738167a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-*
+* Safer check for integer value in Excel
 
 ## [0.6.4] - 2021-12-18
 

diff --git a/src/quorum/formats.py b/src/quorum/formats.py
@@ -99,6 +99,7 @@ def xlsx_to_map(file_path, keys = (), types = (), ignore_header = True):
 def xlsx_raw(cell_s):
     is_str = cell_s.ctype == xlrd.XL_CELL_TEXT
     if is_str: return cell_s.value
-    is_int = cell_s.value == int(cell_s.value)
+    try: is_int = cell_s.value == int(cell_s.value)
+    except ValueError: is_int = False
     if is_int: return legacy.UNICODE(int(cell_s.value))
     return legacy.UNICODE(cell_s.value)