Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new string validations #26

Merged
merged 3 commits into from Jan 12, 2021
Merged

feat: new string validations #26

merged 3 commits into from Jan 12, 2021

Conversation

gcandal
Copy link
Contributor

@gcandal gcandal commented Jan 11, 2021

No description provided.

@gcandal
Copy link
Contributor Author

gcandal commented Jan 11, 2021

@joamag PTAL

joamag
joamag requested changes Jan 11, 2021
View reviewed changes
test/util/validation.js
assert.strictEqual(result, true);

assert.throws(
() => yonius.isLower()("ILLEGAL!"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep using the typical hello and hello world string "HELLO" example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from

yonius/test/util/validation.js

Line 141 in 35e9dcb

() => yonius.isSimple()("illegal!"),

test/util/validation.js Outdated
result = yonius.stringGt(2)("xxx");
assert.strictEqual(result, true);

result = yonius.stringGt(4)("xxxxx");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep using the hello world theme

test/util/validation.js
assert.strictEqual(result, true);

result = yonius.stringLt(4)("xxx");
assert.strictEqual(result, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@joamag joamag added enhancement New feature or request p-medium Medium priority issue labels Jan 11, 2021
@gcandal
Copy link
Contributor Author

gcandal commented Jan 12, 2021

@joamag

@joamag joamag merged commit a330ede into hivesolutions:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamag joamag joamag approved these changes

Assignees

@gcandal gcandal

Labels
enhancement New feature or request p-medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gcandal @joamag