support on fly test of tools #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyouga
requested changes
Feb 25, 2024
src/llmtuner/webui/chatter.py
Outdated
| @@ -115,7 +116,7 @@ def predict( | |||
| temperature: float, | |||
| ) -> Generator[Tuple[Sequence[Tuple[str, str]], Sequence[Tuple[str, str]]], None, None]: | |||
| chatbot.append([query, ""]) | |||
| query_messages = messages + [{"role": Role.USER.value, "content": query}] | |||
| query_messages = messages + [{"role": Role(role), "content": query}] | |||
There was a problem hiding this comment.
Shouldn't it be Role(role).value or just role?
There was a problem hiding this comment.
just role should be fine
lungothrin
force-pushed
the
feature/chatter-with-role
branch
from
50bd5ea
to
56b3918
Compare
hiyouga
approved these changes
Feb 28, 2024
|
LGTM! |
hiyouga
added
solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow user to create observation inputs on web ui to test the effectiveness of tuned model using tools.