Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.Change the name of is_fastapi_available function 2. Added the log of printing requests when deploying using vllm #3655

Merged
merged 3 commits into from
May 13, 2024
Merged

1.Change the name of is_fastapi_available function 2. Added the log of printing requests when deploying using vllm #3655

merged 3 commits into from
May 13, 2024

Conversation

Tendo33
Copy link
Contributor

@Tendo33 Tendo33 commented May 9, 2024 •
edited

What does this PR do?

  1. Fixed function name typo: Corrected the misspelling in the function name is_fastapi_available.
  2. Added request logging: Request logging is now included when deploying using vllm, enhancing debugging and tracking capabilities. Now the console will print out the request：
    image

Before submitting

@Tendo33
1.Change the name of is_fastapi_available function
fd2e6de 
2. Added the log of printing requests when deploying using vllm
@hiyouga hiyouga added the pending This problem is yet to be addressed. label May 11, 2024
@hiyouga
Copy link
Owner

hiyouga commented May 11, 2024

Could you please run make style && make quality?

@Tendo33
Copy link
Contributor Author

Tendo33 commented May 13, 2024

Could you please run make style && make quality?

Done ! thanks for reminding

@hiyouga hiyouga self-requested a review May 13, 2024 09:59
@hiyouga
Copy link
Owner

hiyouga commented May 13, 2024

LGTM!

@hiyouga hiyouga merged commit f7c8edd into hiyouga:main May 13, 2024
1 check passed
@hiyouga hiyouga added solved This problem has been already solved. and removed pending This problem is yet to be addressed. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tendo33 @hiyouga