feat: refresh jsmind can set to center or not #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hizzgdev
reviewed
Jun 19, 2024
src/jsmind.js
Outdated
| this._reset(); | ||
| this._show(mind); | ||
| this._show(mind, _keepCenter); |
There was a problem hiding this comment.
this._show(mind, !!keepCenter);A simpler way is to use double negation operators.
|
主要是为了刷新的时候调用show方法的时可以保持原来的位置。不用!!是为了保持旧版本兼容性On Jun 19, 2024 11:18 AM, Zhigang Zhang ***@***.***> wrote:
@hizzgdev commented on this pull request.
好奇这是一种什么使用场景，打开一个新的脑图难道不应该让它居中显示吗？你是为了“刷新” 当前这个脑图吗?
In src/jsmind.js:
this._reset();
- this._show(mind);
+ this._show(mind, _keepCenter);
this._show(mind, !!keepCenter);
A simpler way is to use double negation operators.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
确实如此。出于这个原因的话我建议把参数改名为 |
hizzgdev
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当刷新或者显示脑图时可以自行选择是否居中
refresh jsmind can set to center or not.