Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

If uptime and downtime overlap the replicaset will be scaled down #28

Open
fbrnc opened this issue Jan 17, 2019 · 2 comments
Open

If uptime and downtime overlap the replicaset will be scaled down #28

fbrnc opened this issue Jan 17, 2019 · 2 comments

Comments

@fbrnc
Copy link
Contributor

fbrnc commented Jan 17, 2019

is_uptime = helper.matches_time_spec(now, uptime) and not helper.matches_time_spec(now, downtime)

In case uptime and downtime overlap this line will evaluate to is_uptime = false resulting in the replica sets to be scaled down.
I wonder if this is excepted/wanted behavior. In case of doubt (e.g. conflicing configuration) I'd rather keep a replica set up and running instead of shutting it down :)

@hjacobs
Copy link
Owner

hjacobs commented Jan 25, 2019

Yes, this behavior is expected, but we can obviously discuss what makes sense in general.

@fbrnc
Copy link
Contributor Author

fbrnc commented Jan 29, 2019

Maybe we could introduce an Apache-style (order deny,allow) flag that controls if uptime or downtime has a higher priority for overlapping configurations, defaulting to downtime having a higher priority for backwards-compatibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants