New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add digest as parameter to crypt routines #10
Conversation
hey @nickgsc 🙌 that loooks great, however, is if it is safe to rely on its availble, i would prefer to use implemenation is great, just a matter of default |
I had that thought too. I suppose defaulting it to md5 would be better for backwards compatibility of existing repos. It is definitely still a supported digest, it's just no longer the default on OpenSSL 1.1 (when it was on older versions of OpenSSL). For reference, here are the available digests I was able to identify in the environments I have at my disposal right now: OpenSSL 1.1.0f (on Debian Jessie):
LibreSSL 2.2.7 (MacOS High Sierra):
OpenSSL 1.0.2o (MacOS via Brew):
|
awesome - many thx for your work ❤️ and your top-notch explanation 💯 |
hey @nickgsc i backported your changes to fastlane/fastlane#12390 |
ohhh i see it already was there :( my fault. |
I didn't realize that this had been forked from match, so I didn't even check that repo for a solution. I just rolled the fix directly here. In any case, glad we have parity on that now between the two! |
Fixes #9