Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eachAttribute does not correctly get the data from the base model data #165

Closed
dnachev opened this issue Jul 30, 2018 · 2 comments
Closed

eachAttribute does not correctly get the data from the base model data #165

dnachev opened this issue Jul 30, 2018 · 2 comments

Comments

@dnachev
Copy link
Collaborator

dnachev commented Jul 30, 2018

The implementation relies on the projection model data's own _data object, which is empty, because all of the data from the projections should come from the base model data.
@hjdivad
Copy link
Collaborator

hjdivad commented Aug 6, 2018

@dnachev presumably this prevents serializing any projection?

@dnachev dnachev closed this as completed Aug 6, 2018
@dnachev dnachev reopened this Aug 6, 2018
@hjdivad
Copy link
Collaborator

hjdivad commented Aug 6, 2018

related: #168

hjdivad added a commit that referenced this issue Aug 30, 2018
@hjdivad
Projections iterate attributes from base
881581c 
Previously, `projectionModel.eachAttribute()` would iterate its local
attributes, which would always be empty as the data are stored in the
base `modelData`.

[Fix #165]
hjdivad added a commit that referenced this issue Sep 11, 2018
@hjdivad
Projections iterate attributes from base
44a217a 
Previously, `projectionModel.eachAttribute()` would iterate its local
attributes, which would always be empty as the data are stored in the
base `modelData`.

[Fix #165]
@hjdivad hjdivad mentioned this issue Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjdivad @dnachev