Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger dot access deprecations when useNativeProperties hook isn't defined #1247

Merged
merged 1 commit into from Aug 2, 2021

Conversation

igorT
Copy link
Collaborator

@igorT igorT commented Aug 2, 2021

No description provided.

@igorT igorT added the bug ch:bugfix label Aug 2, 2021
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Performance Report for 24f35fb

Scenario - materializing: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 52ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-10ms to 4ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-14ms to 31ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [-12ms to 25ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [0ms to 1ms]

Scenario - rendering: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 14ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-3ms to 5ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-1ms to 1ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [0ms to 0ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [-2ms to 10ms]

Copy link
Contributor

@gitstevenpham gitstevenpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Checked with Igor offline to double check if we strictly need boolean

if they haven’t implemented the hook
we don’t want to do any deprecations

@igorT igorT changed the title Do not trigger nativeProperties deprecations when useNativeProperties… Don't trigger dot access deprecations when useNativeProperties hook isn't defined Aug 2, 2021
@igorT igorT merged commit 55aaab2 into master Aug 2, 2021
@igorT igorT deleted the igor/native-props-undefined branch August 2, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ch:bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants