Fix 'firstObject/lastObject' properties in Ember 4 with native proxies #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry-x-yu
changed the title
hjdivad
force-pushed
the
laryu/reproduce-first-object-issue
branch
2 times, most recently
from
7a2ee8f
to
0a897d2
Compare
hjdivad
requested changes
Feb 15, 2023
There was a problem hiding this comment.
@larry-x-yu thanks for digging into this.
I pushed a couple changes
- fixed the linting issues
- changed the implementation to not rely on a heuristic
- run the tests even for non-native proxies (since the test doesn't rely on knowing that implementation detail)
can you please expand the testing assuming the changes look good to you and then we can merge + release?
tests/unit/model/native-access/native-access-arrays-first-object-test.js
Outdated
Show resolved
Hide resolved
hjdivad
force-pushed
the
laryu/reproduce-first-object-issue
branch
from
d8c88c5
to
cdffecc
Compare
added 2 commits
February 16, 2023 11:12
Rather than rely on the implementations from `MutableArray`, implement these utility methods directly for the native proxy.
hjdivad
force-pushed
the
laryu/reproduce-first-object-issue
branch
from
ff0d36a
to
85e9505
Compare
hjdivad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause Analysis
Ember 4.x replaced
arrayContentDidChangewith another function whereas the state of 'firstObject/lastObject' were left open.What has changed
Added a test cases to reproduce the issue and verify the fix.
Fixed the issue by changing how
firstObjectandlastObjectget its value.Testing Done
yarn testpassed locally.@co-authored-by hjdivad