Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaviconsWebpackPlugin #100

Open
nossienl opened this issue Aug 15, 2019 · 2 comments
Open

FaviconsWebpackPlugin #100

nossienl opened this issue Aug 15, 2019 · 2 comments

Comments

@nossienl
Copy link
Collaborator

when setting this to true, you also need to set title in webpack.partial.conf.plugins.js
if you don't do this it tries to guess the name of app/website thru the function guessAppName and this tries to looks that up in package.json.
I don't think everybody changes the package.json to match the website/app name.

maybe we can retreive website title from index.html and set that in webpack.partial.conf.plugins.js

@flut1
Copy link
Collaborator

flut1 commented Aug 15, 2019

I don't think using the html is a feasible solution. The title in the html can also be changed at runtime, which won't be picked up yet at build time. My suggestions:

  1. Don't guess the title, but error indicating that you need to add a title
  2. Use the package.json value but error if that still equals "Vue Skeleton". Added advantage is that devs will more often update the name in the package json :)

@ThaNarie
Copy link

Having a wrong favicon title is something you might not spot early, so using an automatic value from the package.json might also be dangerous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants