Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Succeeded in running on synology NAS #90

Closed
taka0913 opened this issue Sep 22, 2020 · 19 comments
Closed

Succeeded in running on synology NAS #90

taka0913 opened this issue Sep 22, 2020 · 19 comments
Labels

Comments

@taka0913
Copy link

taka0913 commented Sep 22, 2020

Below are the steps I took.

Nodejs is installed on the synology NAS.

Install Java on your NAS.
However, my NAS did not need to be installed because the CPU is arm v7.

If you don’t already have a ‘shared folder’ for your Comics, create one.

Enter administrator mode with "sudo -i".

sudo -i

Install entware-ng. It's a package manager and you can easily install imagemagick.
https://github.com/Entware/Entware-ng

Install imagemagick with entware-ng.

opkg install imagemagick

Install git.

opkg install git
opkg install git-http

git clone https://github.com/hjyssg/ShiguReader

modify src/path-config.
replace "D:" to "/volume1"
for example "/volume1/Comic" if shared folder is "Comic".

modify src/config/user-config.js.
replace "D:" to "/volume1"
replace "\" to "/"
for example "/volume1/Comic/_Happy_Lesson/_Going_to_sort/_good/"

7z is included in Synology NAS as standard, but there was a problem, so install it separately.

opkg install p7zip

cd ShiguReader

npm install
If some packages fail to install with a warning, force them to install with the "--force" command.

run.

npm run dev

It's works.

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

Awesome! Thank you very much!

@taka0913
Copy link
Author

I like this tool very much, but it is not accessible from the outside.
That's because anyone can see the page if they know the URL.
So I hope this tool implements user login functionality.

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

ShiguReader is not safe when it can be accessed from public IP. The server code is not prepared for any cyber attack.

Let me guess your use case.
If you just want to watch comic or anime when you are not at home, you can just download files into you tablet.
For example, my ipad has VLC for video and ComicGlass for comic. I download file in Chrome browser and save them to my app. So I can read comic when going outside.

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

Or you dont want your family members see your personal comic collection even they know the URL. Then I can add a small password page, such that only the person who knows the password can open and read ShiguReader.

Which one is your use case?

@taka0913
Copy link
Author

I understand that it is dangerous from a security point of view.
So I give up accessing from outside the house.
But it's also true that, as you say, I don't want my family to see the site.
Could you please add a simple password page?

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

Hahah, sure, I will add a simple password page.

@taka0913
Copy link
Author

Thank you very much.
By the way, I want to remove the download button, where should I comment it out?

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

It is at FileChangeToolbar.js renderDownloadLink()

@taka0913
Copy link
Author

taka0913 commented Sep 25, 2020

I got these errors when I commented out.
And the site froze.

[HPM] Error occurred while trying to proxy request /api/lsDir from 192.168.1.2:3000 to http://localhost:8080 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[HPM] Error occurred while trying to proxy request /api/getGoodAuthorNames from 192.168.1.2:3000 to http://localhost:8080 (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

It is totally unrelated, are you using any vpn or proxy?

@taka0913
Copy link
Author

No. I'm not using it.

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

image

All you need to do is as above. Not sure if you change any other code

@taka0913
Copy link
Author

I see. I understand the cause. I commented out too much.

image

@taka0913
Copy link
Author

It works fine. Thank you for your polite advice.

@hjyssg
Copy link
Owner

hjyssg commented Sep 25, 2020

Hahah, it is my pleasure.

@hjyssg
Copy link
Owner

hjyssg commented Sep 26, 2020

befc01d
I added a password page

image

image

hjyssg added a commit that referenced this issue Sep 26, 2020
a small new feature requested by #90
@taka0913
Copy link
Author

Wow. Thank you for updating so quickly. The password page works in my environment as well.

@hjyssg
Copy link
Owner

hjyssg commented Sep 26, 2020 via email

@taka0913
Copy link
Author

Thank you for your reply.
The cause was cloned to the root folder, so there wasn't enough space set.
Now I have moved the code below /volume1 so no error has occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants