Add Azure Regions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the Graph API from the Azure AD Graph to the Microsoft Graph endpoint. This will future-proof the code, as Microsoft has deprecated Azure AD Graph.
Change Graph URL usages to a getter rather than using the string constants directly.
Add configuration option to allow user to select a “national cloud” to login against. Adjust methods to use the new settings. Update tests to cover the new and updated code.
|
As a note, the settings for the plugin need some serious cleanup and organizing, but I felt that this PR was not a good place to make these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add the ability to select from one of Microsoft's Azure National Clouds for authentication. It also migrates from the Azure Graph API to the Microsoft Graph API to support all the regions.
The endpoint URLs for login and graph were gathered from https://developer.microsoft.com/en-us/graph/docs/concepts/deployments.
Testing was done as best as possible, but I don't have any accounts in the national clouds to fully verify the flow works 100%.
Fixes #43