Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX "continue" targeting switch is equivalent to "break". Did you mea… #21

Merged
merged 2 commits into from
Mar 24, 2019

Conversation

bvis
Copy link
Contributor

@bvis bvis commented Mar 20, 2019

…n to use "continue 2"? WARNING

From PHP 7.3 the usage of continue in a switch statement produces a WARNING, under certain configurations it can produce an error exception

bvis and others added 2 commits March 20, 2019 14:56
…n to use "continue 2"? WARNING

From PHP 7.3 the usage of `continue` in a switch statement produces a WARNING, under certain configurations it can produce an error exception
@hkarlstrom
Copy link
Owner

I did mean continue 2 :)
I refactored it to be more readable, thanks for pointing out the issue!

@hkarlstrom hkarlstrom merged commit f9bc06e into hkarlstrom:master Mar 24, 2019
@bvis
Copy link
Contributor Author

bvis commented Mar 24, 2019

Much better after the refactor, thanks.

@bvis bvis deleted the patch-1 branch March 24, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants