Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upack #24

Merged
merged 1 commit into from Jun 8, 2022
Merged

Feature/upack #24

merged 1 commit into from Jun 8, 2022

Conversation

shblue21
Copy link
Contributor

Azure DevOps java sdk pull request template guide

Hello.

I have implemented a Universal Package API
and refactor maven API

Unviersal Package is an artifact that can be published/downloaded regardless of the language of the project.
https://docs.microsoft.com/en-us/rest/api/azure/devops/artifactspackagetypes/universal?view=azure-devops-rest-7.1

Regards,

Description

Describe your PR in few words.

PR Checklist

  • Added help
  • Added unit test/s
  • Updated Change log

@shblue21
Copy link
Contributor Author

Could you please publish the Universal Package for testing? I will edit the test code.

@shblue21 shblue21 force-pushed the feature/upack branch 4 times, most recently from 53589ff to db084d5 Compare May 30, 2022 06:28
@hkarthik7
Copy link
Owner

@shblue21, thanks for adding the UPack Api. I've published a packaged universal-package with version 1.0.0 and a package exists in recycle bin universa-package with version 1.0.0.

@shblue21 shblue21 force-pushed the feature/upack branch 2 times, most recently from 6a60dfc to bcb70b7 Compare June 2, 2022 02:32
@shblue21
Copy link
Contributor Author

shblue21 commented Jun 2, 2022 •
edited

@hkarthik7 Thanks for publishing for the test case.
I have a question because the test failed for an unknown reason.

Are Linux Test and Windows Test running concurrently in Azure pipeline?
The same test seems to succeed on Windows and fail on Linux.

e.g

  • normal process : createProject(Linux) -> deleteatProject(Linux)
  • fail process : createProject(Linux) ->createProject(Windows, already exists exception) -> deleteatProject(Linux)

@hkarthik7
Copy link
Owner

@shblue21 that's right, tests for Windows and Linux runs parallel. I will update the tests so that it won't fail.

hkarthik7
hkarthik7 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Owner

@hkarthik7 hkarthik7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shblue21, LGTM. Can also please add help contents?

@hkarthik7 hkarthik7 added the enhancement New feature or request label Jun 7, 2022
@hkarthik7 hkarthik7 self-assigned this Jun 7, 2022
@hkarthik7
Copy link
Owner

@shblue21 thanks for adding the help, appreciate it. Can you please resolve the conflicts for me to merge the changes?

@shblue21 shblue21 force-pushed the feature/upack branch 2 times, most recently from bb07414 to 525d402 Compare June 8, 2022 05:10
@shblue21
Added Universal Package Api
a799790 
- Added Universal Package Api
- Change maven Enum to common PackagePromote, PackageOperation
- Added exception handling updatePackageVersions
- add comments, etc
@shblue21
Copy link
Contributor Author

shblue21 commented Jun 8, 2022 •
edited

Sorry for the late reply. Conflicts were resolved. Thanks for the feedback.

@hkarthik7 hkarthik7 merged commit 7a0c95e into hkarthik7:main Jun 8, 2022
@shblue21 shblue21 deleted the feature/upack branch June 8, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkarthik7 hkarthik7 hkarthik7 approved these changes

Assignees

@hkarthik7 hkarthik7

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shblue21 @hkarthik7