Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce --flatten (or something else like --output_filter=flatten) #81

Closed
hkoba opened this issue Apr 2, 2020 · 0 comments
Closed
Assignees

Comments

@hkoba
Copy link
Owner

hkoba commented Apr 2, 2020

Previously in #78 I deprecated --flatten for usage consistency. But I recognized it complicates life with more structured files.

For example, xlsx workbook contains worksheets, which constructed from rows, each of which is an array of columns. Emitting a workbook as a single JSON array is correct, but post-processing of such JSON usually requires complex jq filtering. It is quite time-consuming.

Instead, if such a workbook is emitted as row-by-row ndjson, we can easily spot interesting items with grep and/or less. And you can still use jq for it too.

One idea to solve above is introducing --output_filter=flatten and allow users to implement their own filters.

@hkoba hkoba self-assigned this Apr 2, 2020
hkoba added a commit that referenced this issue Jun 28, 2020
@hkoba hkoba closed this as completed Jun 28, 2020
hkoba added a commit that referenced this issue Jun 28, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index c7ddfb2..10f4145 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,17 @@
 Revision history for Perl extension MOP4Import::Declare

+0.051    2020-06-28
+    * GH-81 - Reintroduce `--flatten`
+    * GH-80 - Allow opts in ->cli_encode_as([$fmt,\%opts], @records)
+    * GH-79 - change Data::Dumper options for --output=dump
+    * GH-78 - make --output=ndjson as default format
+    * GH-77 - cli_read_file - pass %opts to each format readers
+    * GH-75 - Change NamedCodeAttributes to Exporter
+    * GH-74 - Prepare MOP4Import::Util::Inspector to implement zsh completer
+    * GH-73 - Rename run() to cli_run(). (run() was too generic as an API entry name.)
+    * GH-72 - Fix tsv output and add cli_encode_as($outputFmt, @records)
+    * GH-57 - separate cli_array (returns `\@args`) and cli_list (returns `@args`)
+
 0.050    2019-09-11
     * MOP4Import::Base::CLI_JSON is introduced with many cli_xxx APIs.
     * Other important changes follows:
hkoba added a commit that referenced this issue Dec 2, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index 10f4145..0e7cafe 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
 Revision history for Perl extension MOP4Import::Declare

+0.051_001 2020-10-14
+    * GH-83 - Fix cpanfile for configure dependency of `rlib`
+
 0.051    2020-06-28
     * GH-81 - Reintroduce `--flatten`
     * GH-80 - Allow opts in ->cli_encode_as([$fmt,\%opts], @records)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant