Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.tbl_deep_extend is for map-type tables #43

Merged
merged 1 commit into from Jan 16, 2022

Conversation

jdelkins
Copy link
Contributor

I'm not quite sure what the plan is in the transition from bootstrap() to
setup() but vim.tbl_deep_extend is for map-type tables and the new bindings
layout is not that, but rather a list-type table. Accordingly, this works
better.

@hkupty
Copy link
Owner

hkupty commented Jan 16, 2022

Thanks for the PR.

The idea of moving to .setup{} is to centralize configuration in a single command rather than a few commands that require a "commit" phase afterwards. It should look more like other newer neovim plugins now, rather than something odd..

Finally, this allows for a rework in the internals simplifying the code, which makes nvimux much simpler, since it should not be very complex anyways.

@hkupty hkupty merged commit 029e107 into hkupty:master Jan 16, 2022
@jdelkins
Copy link
Contributor Author

jdelkins commented Jan 16, 2022

Great, thanks for continuing to maintain the repo! I've been using it for years and love it. Good luck with the modernization

@hkupty
Copy link
Owner

hkupty commented Jan 16, 2022

Thanks! Really glad you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants