Remove deprecated functions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to make use of <Cmd>
This allows to skip autocmds when changing mode + is less intrusive on the user
This should be better by avoiding swapping back-and-forth between lua and viml. Those lua commands are usually simple façades to lua functions and defined only as convenience mappings anyways.
Also, simplify the structure and create a new wrapper
Also, document a few of the properties
They were very similar and introduced an unnecessary indirection. This should be simpler now
Also, fixes a little bug in which context was not taken in account when reading the values
It should only be used when running the setup
It should not be immediately available. If someone needs it, it can
still be accessed by `require("nvimux.bindings")`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this PR contains a few nice improvements:
<Cmd>mappings, avoiding autocmdsnormal paand other hacks.Hopefully nothing changes to the user, but if anything the responsiveness should improve with those small tweaks.