Optional Arguments #220
Draft
Optional Arguments #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename functions from `visitX` to `traverseX`. - Add Boolean condition test cases. - Use dollar symbol in generated variables. - Add `TupleCase` which currently is commented.
This commit was cherry-picked from a future commit which changed many files.
- Very minor but important: should use post-processed term as the desugared term. - Add incomplete AVL tree test cases which reveals many problems. - Cache operator split partial terms for efficiency. - `Traceable` now supports filtering debugging by topics. - Skip speicalization Boolean condition scrutinees.
and clean up some code...
We used to generate let bindings which destruct class parameters during normalization. This works fine but it exposes some inflexibility. For example, in the previous commit, I added a case where free variables from a absorbed case branch are shadowed. If we moving let bindings generation to desugaring stage, the problem can be solved easily. This change also paves the road for duplicated branch lifting.
Normalization stage is greatly simplified from now!
also support traversing let bindings
This is a refactor and not test changes were found.
Finally! I made this. In this commit, we track and store the information of scrutinee through the context of per-UCS-term; at the same time, we decouple the scrutinee and term symbol. This has the following advantages. 1. The symbol corresponding to each variable can store information from different UCS terms. 2. The error location of the scrutinee is more precise. 3. This enables coverage checking to take advantage of previously collected patterns, eliminating the need to traverse the term again. In addition, there are a few minor changes. 1. All functions used for pretty printing have been extracted into a separate package, namely `mlscript.ucs.display`. 2. Common operations about `Var` have been extracted into an implicit class in `DesugarUCS` base class.
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
New UCS desugarer and rudimentary `PreTyper`
|
Hi @noordahx, thanks for the PR draft. Do you need some assistance in moving it forward? |
noordahx
commented
May 27, 2024
Comment on lines
18
to
26
| //│ ╔══[ERROR] Type mismatch in operator application: | ||
| //│ ║ l.17: fun f1(a: Int, b: Int) = a + b | ||
| //│ ║ ^^^^^ | ||
| //│ ╟── type `()` is not an instance of type `Int` | ||
| //│ ║ l.17: fun f1(a: Int, b: Int) = a + b | ||
| //│ ║ ^^^ | ||
| //│ ╟── but it flows into reference with expected type `Int` | ||
| //│ ║ l.17: fun f1(a: Int, b: Int) = a + b | ||
| //│ ╙── ^ |
There was a problem hiding this comment.
Hi @LPTK , I am having trouble with function parameter type parsing (seems all of the parameter types are '()' by default)
There was a problem hiding this comment.
NewParser.scala "?" parser -> line
There was a problem hiding this comment.
That code does not make much sense to me. You may have mismerged the conflicts. The code is computing (argName, argOpt) by consuming an identifier, ?, and : tokens. And then it redundantly checks optionality with isOptional – the logic is all messed up. I'm guessing the () might come from consuming the type tokens and then parsing an empty expression (which produces undefined, aka ()), or it could be the later logic to make things optional that's broken. It might be better to start the parsing change from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR: