Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestGroup discussion #190

Closed
bdc-ehealth opened this issue Nov 17, 2022 · 11 comments
Closed

RequestGroup discussion #190

bdc-ehealth opened this issue Nov 17, 2022 · 11 comments

Comments

@bdc-ehealth
Copy link
Collaborator

WG:
After alignment with the VIDIS project (and if they agree):

  1. We would like to use a RequestGroup to group requests, even if there is only one request at this moment.
  2. If requests in a RequestGroup do not have a temporal/causal relationship, they should also be grouped in a RequestGroup.

RequestGroup or other resource with a similar name.

Please add relevant usecases to the Google doc here: https://docs.google.com/document/d/1s2GNrXXWd5jDZT9ZyEIE54N1VC6Ukz8Fv18LWy6XNh8/edit

@bdc-ehealth bdc-ehealth added this to Inbox in Development issues via automation Nov 17, 2022
@bdc-ehealth bdc-ehealth moved this from Inbox to To do (Solution validated by WG) in Development issues Nov 17, 2022
@bdc-ehealth
Copy link
Collaborator Author

related to #183

@costateixeira
Copy link
Contributor

We have a negative answer now, so we have time to regroup.
Suggest to close this and reopen a clean discussion.

@bdc-ehealth
Copy link
Collaborator Author

bdc-ehealth commented Nov 24, 2022

This is getting too difficult for me... Baseline for me: we still have no solution.

@costateixeira
Copy link
Contributor

costateixeira commented Nov 24, 2022 via email

@bdc-ehealth bdc-ehealth moved this from To do (Solution validated by WG) to Inbox in Development issues Nov 24, 2022
Development issues automation moved this from Inbox to Done Nov 24, 2022
@bdc-ehealth
Copy link
Collaborator Author

WG: we decide to continue using the RequestGroup, and we are conscious of the fact that we deviate from the recommendation of the norm. This has no technical impact on the servers.

@bdc-ehealth bdc-ehealth moved this from Done to To do (Solution validated by WG) in Development issues Nov 24, 2022
@bdc-ehealth bdc-ehealth reopened this Nov 24, 2022
Development issues automation moved this from To do (Solution validated by WG) to In progress Nov 24, 2022
@bdc-ehealth
Copy link
Collaborator Author

@MatonAnthony

[13:16] Anthony Maton (Smals)
Just a note #190 (comment)

If the "servers" you refer to is UHMEP, it has an impact.

Maintainability when we will want to align with the standard (which will happen)Increased complexity to manage those case where all of that RequestGroup is useless (which is a specific that will come with its set of rules)Increased storage of data
It's not "simpler" like people seems to think, it's added complexity.

@bdc-ehealth
Copy link
Collaborator Author

bdc-ehealth commented Dec 8, 2022

WG: Hans will go back to his team to see whether they agree with Anthony's opinion. Anthony will send his slides to the WG.
HL7BE_WG_RequestGroup.pptx

@bdc-ehealth
Copy link
Collaborator Author

bdc-ehealth commented Dec 15, 2022

Feedback by Hans and Anthony:

Hello Bart,

Beneath you can find our correspondence about the RequestGroup – ServiceRequest.

So we can agree with the approach of Anthony which is in line with HL7 if we can easily fetch the RequestGroup for a ServiceRequest.
We can discuss this further in the WG.

Met vriendelijke groeten,
Cordialement,
Kind regards,

Hans De keersmaecker
Product owner
 
Luchthavenlaan 25A

1800 Vilvoorde (Belgium)

www.corilus.be

From: anthony.maton@smals.be anthony.maton@smals.be
Date: Thursday, 15 December 2022 at 14:10
To: Hans De Keersmaecker hans.dekeersmaecker@corilus.be
Subject: RE: HL7 Belgium WG referral - biweekly meetings
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello Hans,

We can talk about it before the meeting. I can free anytime that works for you before the meeting, just send me an invite that works for you.
For us there should never be a ServiceRequest in multiple RequestGroup, we never received any usecase going in that direction, so unless this business case appears it’s not taken in account in our proposal.

We can probably provide a search parameter to allow to find RequestGroup containing a specific ServiceRequest

Sincerely,
Anthony

From: Hans De Keersmaecker hans.dekeersmaecker@corilus.be
Sent: Thursday, 15 December 2022 13:50
To: Anthony Maton (SMALS) anthony.maton@smals.be
Subject: Re: HL7 Belgium WG referral - biweekly meetings

Hi Anthony,

The solution of slide 2 was not how we had it in mind.

If you create ServiceRequestB that has a relationshipB, we wouldn’t create RequestGroupB.
We would immediately add it to requestGroupA with the correct relationship.

Of course, if you didn’t know that there was a relationship and they were created before with ServiceRequestA-RequestGroupA and ServiceRequestB-RequestGroupB and you need to add the relationship. You must move ServiceRequestB to requestGroupA and you can remove requestGroupB (or visa versa).

In the example that we don’t create requestGroup/ServiceRequests.
What we see as difficulty is that we must call both requestGroups & ServiceRequets in order to make changes.
You don’t have 1 call to fetch all information, which can be the case if the Groups are always created.

In your example: you create ServiceRequest A at first. Then you create ServicRequest B. If you want to add a relationship between ServiceRequest B & ServiceRequest A. You fetch A, you first ask for all requestgroups that contain A. You must perform the same for B. We hope that we don’t need to fetch all Groups to do this. And then you must see if a group was created by somebody else for them, this may or may not be the case and how to link them.
If we won’t need to fetch all groups to identify that a ServiceRequest is added to them. But we can immediately fetch the RequestGroup for the ServiceRequest, we think the new solution will also work.

If you want to have a call on this, I can send you a Teams link to have a discussion before the meeting at 16h.
Let me know.

Met vriendelijke groeten,
Cordialement,
Kind regards,

Hans De keersmaecker
Product owner
 
Luchthavenlaan 25A

1800 Vilvoorde (Belgium)

www.corilus.be

@bdc-ehealth
Copy link
Collaborator Author

WG: we agree on the principle as described above. We will provide another diagram which makes the final choice clear. The only thing to solve is to determine how the requestgroup can easily be retrieved from the servicerequest. This can be done either by an extra extension, or by an API feature (such as _reverseinclude), but this is to be investigated.

@bdc-ehealth
Copy link
Collaborator Author

WG: we wait for the architecture diagram that Anthony will provide.

@bdc-ehealth
Copy link
Collaborator Author

WG: solved by the proposal by RIZIV-INAMI/SMALS https://drive.google.com/file/d/156V7Pjw_ZYs4RGEit8HVFi0DhSEjduqo/view?usp=share_link

Development issues automation moved this from In progress to Done Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants