Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the current terminology for Reason Vaccine Not Administered #745

Closed
dtr-agency opened this issue Aug 24, 2022 · 1 comment · Fixed by #746
Closed

Include the current terminology for Reason Vaccine Not Administered #745

dtr-agency opened this issue Aug 24, 2022 · 1 comment · Fixed by #746
Assignees

Comments

@dtr-agency
Copy link
Contributor

The existing preferred Australian set is outdated and includes inactive concepts. The latest value set should be included (published last month).

Please update the binding of Reason Vaccine Not Administered value set on Immunization.statusReason from -1 to -3 in AU Base Immunisation.

<binding>
        <strength value="preferred"/>
        <valueSet value="https://healthterminologies.gov.au/fhir/ValueSet/reason-vaccine-not-administered-3"/>
</binding>
@davidmckillop
Copy link
Contributor

Work has been done to update the binding of Reason Vaccine Not Administered value set on Immunization.statusReason from -1 to -3 in AU Base Immunisation.

PR to follow.

brettesler-ext pushed a commit that referenced this issue Aug 26, 2022
* Correction to AU Local Dispense Identifier definition

The text in the definition was corrected to align with the "AU Local dispense identifier.identifier" definition.
Fixes #738

* Encounter.serviceType and Encounter.type binding update to NCTS content

The binding for Encounter.type was changed to https://healthterminologies.gov.au/fhir/ValueSet/encounter-type-1 with preferred binding.
The binding for Encounter.serviceType was changed to  https://healthterminologies.gov.au/fhir/ValueSet/service-type-1 with preferred binding.  

The following testing was done:
- The valuesets (expanded form) were downloaded from NCTS and created as valuesets (valueset-encounter-type-1.xml & valueset-service-type-1.xml), added to ig.xml and ig.json.
For testing purposes the binding was changed from "preferred" to "required" and the existing encounter examples were modified:
- to include an element from the valueset => PASS
- to not include an element from the valueset => FAIL
Testing outcome was as expected.

* Organization.type comment has been updated with relevant usage notes

The Organization profile "Usage notes" that were specific for the element Organization.type have been copied to the comment field of the Organization.type element.
No additional errors or warning is the structureDefinition file or the existing (8) organization examples.
Fixes GitHub #333.

* Fixes related to minor issues on qa.html file

A number of minor issues present in the qa.html files were resolved  by either fixing the example or adding exceptions to the ignoreWarnings file.

* Reverting changes relating to Core content

Initial changes were made to tidy up the qa.html file in AU Base, but this content has already or about to be moved from AU Base to AU Core and hence no further changes need to be made to the content in/destined for AU Core.

* Change to au-pathologyresult.category 

The structure of the slice for au-pathologyresult.category was changed to reflect the intent of the slice where once category = "laboratory" is mandatory and the other optional category from https://healthterminologies.gov.au/fhir/ValueSet/pathology-diagnostic-service-category-1 with binding = extensible.
Testing done on slice:
1) correct categories: category = "mandatory" and "SR".  expected outcome = pass.  Actual outcome = PASS.
2) No category.  expected outcome = fail. Actual outcome = FAIL.
3) wrong category : category = "imaging" & "SR" (audiology); expected = fail x1 (on imaging); Outcome = FAIL
4) wrong category (slice changed from "extensible" to "required" for testing purposes): category = "imaging" & "AU" (audiology); expected = fail; Outcome = FAIL (found 0)

Minor change to au-imagingresult to correct the order of the elements.

* Change of change to au-pathologyresult.xml

Change of date in the au-pathologyresult structureDefinition file.

* Updating terminology for Reason Vaccine Not Administered

In au-immunization the the terminology for "Reason Vaccine Not Administered" has been updated to https://healthterminologies.gov.au/fhir/ValueSet/reason-vaccine-not-administered-3. 

Testing:
1)with binding as "preferred":
a) code (1620681000168106) from new CodeSystem (sct)in updated immunization-example0.xml; expect = Pass; Actual = Pass.
b) old code (PATOBJ) from old CodeSystem (http://terminology.hl7.org/CodeSystem/v3-ActReason); expect = Pass; Actual = Pass.
c) Non-related code (laboratory) from CodeSystem (http://terminology.hl7.org/CodeSystem/observation-category); Expect = Pass; Actual = Pass 
 
2)with binding as "required" - only changed to "required" and added valueset to IG for testing purposes only:
a) code (1620681000168106) from new CodeSystem (sct)in updated immunization-example0.xml; expect = Pass; Actual = Pass.
b) old code (PATOBJ) from old CodeSystem (http://terminology.hl7.org/CodeSystem/v3-ActReason); expect = Fail; Actual = Fail.
c) Non-related code (laboratory) from CodeSystem (http://terminology.hl7.org/CodeSystem/observation-category); Expect = Fail; Actual = Fail 
 
Fixes GitHub #745

* Adding line to ignoreWarnings.txt file

Adding the line  "	The valueSet reference https://healthterminologies.gov.au/fhir/ValueSet/reason-vaccine-not-administered-3 on element Immunization.statusReason could not be resolved"  to the ignoreWarnings.txt file.

* Corrections following peer review

Corrections to au-localdispenseidentifier-intro.md and au-pathologyresult.xml following peer review.

* Corrections to ignoreWarnings file

An existing ignoreWarning entry was updated rather than creating a totally new entry.

* Additions to ignoreWarnings file

2 additional lines were added to the ignoreWarnings file as a result of changes made for au-encounter

* Removal of added ignoreWarnings that are relevant to  the Core

Some ignoreWarning lines were added to this PR, but they are relevant to content that is going to the Core rather than AU Base.  Hence these liines added to this PR are being removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants