Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of codes from value sets with extensible binding (Michaela Ziegler, ahdis ag) #126

Closed
ziegm opened this issue Sep 10, 2022 · 2 comments · Fixed by #167
Closed

Validation of codes from value sets with extensible binding (Michaela Ziegler, ahdis ag) #126

ziegm opened this issue Sep 10, 2022 · 2 comments · Fixed by #167
Assignees
@pjolo
Labels
IG publisher ready for review STU 3 Ballot Comments/Issues from the Ballot 2022 value set Value set related issue
Milestone
STU3

Comments

@ziegm
Copy link
Collaborator

ziegm commented Sep 10, 2022

We noticed, that no warning is shown if the code is not included in a value set with extensible binding:
e.g.: Medication ingredient: 387165009 - Enalapril maleate (substance) -> not included in this value set

See raised discussion on zulip.

With adding this IG parameter, the validation shows the warning when codes are not in extensible bindings:
allow-extensible-warnings
@ziegm ziegm added the STU 3 Ballot Comments/Issues from the Ballot 2022 label Sep 10, 2022
@ziegm ziegm mentioned this issue Sep 10, 2022
Closed
@ziegm ziegm added the value set Value set related issue label Sep 10, 2022
@ziegm ziegm self-assigned this Oct 26, 2022
@ziegm ziegm added this to the STU 3 milestone Oct 26, 2022
ziegm added a commit that referenced this issue Nov 2, 2022
@ziegm
set allow-extensible-warnings = true (#126)
151149f
@ziegm ziegm assigned pjolo and unassigned ziegm Nov 2, 2022
@ziegm ziegm linked a pull request Nov 2, 2022 that will close this issue
set allow-extensible-warnings = true (#126) #167
Merged
@ziegm
Copy link
Collaborator Author

ziegm commented Nov 2, 2022

@pjolo
Please review the changes:

  • set IG parameter (see here)
  • added example with code not included in VS -> see warning here
  • change log

@pjolo
Copy link
Collaborator

pjolo commented Nov 2, 2022

Checked and good for me.

@ziegm ziegm closed this as completed in #167 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjolo pjolo

Labels
IG publisher ready for review STU 3 Ballot Comments/Issues from the Ballot 2022 value set Value set related issue
Projects
None yet
Milestone
STU3
Development

Successfully merging a pull request may close this issue.

set allow-extensible-warnings = true (#126) hl7ch/ch-emed
2 participants
@ziegm @pjolo