Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates according to new IG publisher (Michaela Ziegler, ahdis ag) #234

Closed
ziegm opened this issue Sep 12, 2023 · 9 comments · Fixed by #239
Closed

Updates according to new IG publisher (Michaela Ziegler, ahdis ag) #234

ziegm opened this issue Sep 12, 2023 · 9 comments · Fixed by #239

Comments

@ziegm
Copy link
Collaborator

ziegm commented Sep 12, 2023

the new version of the ig publisher generates more warnings than before. evaluate which one would need adaptations.
http://build.fhir.org/ig/hl7ch/ch-emed/branches/master/qa.html

Warnings:

  1. UCUM codes
  2. resource narrative
  3. Observation.performer
  4. expression

Changes:

  1. Usage of SCT instead of UCUM
  2. Nothing to adapt -> IG publisher issue
  3. Fixed with Authorship fields #241
  4. Fix rules (see commit)

Edited 16.11.2023

@ziegm
Copy link
Collaborator Author

ziegm commented Sep 14, 2023

  1. IG publisher warning:
    UCUM Codes that contain human readable annotations like {Package} can be misleading. Best Practice is not to use annotations in the UCUM code, and rather to make sure that Quantity.unit is correctly human readable
                <value value="1"/>
                <unit value="Package"/>
                <system value="http://unitsofmeasure.org"/>
                <code value="{Package}"/>

https://hl7.org/fhir/R4/valueset-ucum-units.html & http://fhir.ch/ig/ch-emed/ValueSet-UnitCode.html
code: {Package}
display: Package

https://chat.fhir.org/#narrow/stream/179166-implementers/topic/UCUM.20Codes.20-.20human.20readable.20annotations.20.7B.7D

https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/source.20of.20new.20warning.20popping.20up

https://unitsofmeasure.org/ucum see §6 curly braces


13.10.2023: Summarize research

Zulip
UCUM Codes - human readable annotations {}
source of new warning popping up

image

Quantity with UCUM codes

Quantity as it is currently

<value value="1"/>
<unit value="Package"/>
<system value="http://unitsofmeasure.org"/>
<code value="{Package}"/>

Quantity as it should be (best practice)

<value value="1"/>
<unit value="Package"/>
<system value="http://unitsofmeasure.org"/>
<code value="1"/>

image
image

VS with UCUM codes

http://fhir.ch/ig/ch-emed/ValueSet-UnitCode.html as it is currently
Code: {Package}
Display: Package

VS as it should be (see also https://www.hl7.org/fhir/valueset-ucum-common.html)
Code: 1
Display: 1*

Neccessary changes:

  • add "1" to the VS
  • remove the codes with {} from the valueset
  • add the codes (e.g. {package}) to another element -> Quantity.unit with VS (extensible)
    image

@ziegm
Copy link
Collaborator Author

ziegm commented Sep 14, 2023

  1. IG publisher warning:
    Rule dom-6: 'A resource should have narrative for robust management' Failed (Best Practice Recommendation)

https://chat.fhir.org/#narrow/stream/179280-fhir.2Finfrastructure-wg/topic/dom-6.20is.20a.20problem

@ziegm
Copy link
Collaborator Author

ziegm commented Sep 14, 2023

ziegm added a commit that referenced this issue Sep 14, 2023
@ziegm ziegm linked a pull request Sep 14, 2023 that will close this issue
@ziegm
Copy link
Collaborator Author

ziegm commented Sep 14, 2023

  1. New IG publisher warning
    The left side is inherently a collection, and so the expression ... may fail or return false if there is more than one item in the content being evaluated

@ziegm
Copy link
Collaborator Author

ziegm commented Oct 19, 2023

19.10.2023, PJ/OE/MZ

  1. UCUM
    var 1: as it is
    var 2: own CH EMED CS
    var 3: CH SCT extension -> check this var
  2. --
  3. ok
  4. adapt expression

@ziegm
Copy link
Collaborator Author

ziegm commented Oct 21, 2023

  1. UCUM (https://fhir.ch/ig/ch-emed/ValueSet-UnitCode.html)
  • {Dose} - "Dose"
  • 10*6.{Unit} - "(the number ten for arbitrary powers ^ 6) * Unit
  • {Package} - "Package"
  • {Piece} - "Piece"
  • 10*3.{Unit} - "Thousand Per * Unit"
  • {Unit} - "Unit"

@PeroGrgic
Because we shouldn't use UCUM annotation values (e.g. {Package}) as codes and there are no SCT codes for those 6 values above, would it be possible to add those in the Swiss SCT Extension?

ziegm added a commit that referenced this issue Oct 21, 2023
@ziegm
Copy link
Collaborator Author

ziegm commented Oct 31, 2023

Feedback von Pero:

Mittlerweile wurde SNOMED im Bereich der Units erweitert:

408102007 |Unit dose (qualifier value)| à Dose
1681000175101 |Package - unit of product usage (qualifier value)| à Package
767525000 |Unit (qualifier value)| à Unit
2011000175108 |Thousand unit (qualifier value)| à 103.{Unit} - "Thousand Per * Unit"
396186001 |Million unit (qualifier value)| à 10
6.{Unit} - "(the number ten for arbitrary powers ^ 6) * Unit

Für “Stück”/”Piece” habe ich nichts Passendes gefunden. Ich frage nochmals bei SNOMED International nach, warum piece nicht als Unit eingeführt wurde. Falls SNOMED International auch keinen passenden Code hat oder er einfach noch nicht eingeführt wurde, können wir ihn im International Release einreichen oder, falls SNOMED ihn ablehnt, in die Swiss Extension aufnehmen.

Für beide Möglichkeiten sehe ich die Einführung des Codes nicht vor Dezember/Januar.

@ziegm
Copy link
Collaborator Author

ziegm commented Nov 16, 2023

@pjolo Please review the changes (changelog):

  1. Usage of SCT instead of UCUM
  2. Nothing to adapt -> IG publisher issue
  3. Fixed with Authorship fields #241
  4. Fix rules (see commit)

@ziegm ziegm removed their assignment Nov 16, 2023
@pjolo
Copy link
Collaborator

pjolo commented Nov 22, 2023

The changes are good

ziegm added a commit that referenced this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants