Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream isolation via EDNS0 #4

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

JeremyRand
Copy link
Contributor

@JeremyRand JeremyRand commented Apr 11, 2019

This is an API-breaking change.

This is an API-breaking change.
@JeremyRand JeremyRand changed the title (WIP) Add stream isolation via EDNS0 Add stream isolation via EDNS0 Oct 11, 2019
@JeremyRand
Copy link
Contributor Author

@hlandau This is ready for review. You can test it by building ncprop279 with the following PR's applied in addition to this one:

namecoin/ncdns#97
namecoin/ncprop279#9

Typing the following into ncprop279's STDIN should work fine as before:

RESOLVE 1 domob.bit

Typing the following should yield an error about the stream isolation ID not being passed to namecoind:

RESOLVE 1 domob.bit FOO

(Obviously, that error will be replaced later with functionality that passes the stream isolation ID to namecoind, but that's out of scope for this PR, and is blocked on a Conformal PR.)

@hlandau hlandau merged commit f388686 into hlandau:master Oct 11, 2019
@hlandau
Copy link
Owner

hlandau commented Oct 11, 2019

v2.0.0 tagged (breaking API change). @JeremyRand

JeremyRand added a commit to namecoin/ncdns that referenced this pull request Oct 19, 2019
06d6efb backend: Stream-isolate LRU cache (JeremyRand)
ed8fa68 Add plumbing for stream isolation (JeremyRand)

Pull request description:

  This PR adds the plumbing for stream isolation (from madns to namecoin, without passing the stream ID to namecoind), and stream-isolates the LRU cache.  A follow-up PR will pass the stream ID to namecoind; that's currently blocked on #103 .

  Prerequisites:

  - [x] Merge hlandau/madns#4
  - [x] Merge hlandau/madns#5
  - [x] Tag a madns release (with major version 2).
  - [x] Replace `madns.v1` dependency with `madns.v2`.
  - [x] Tag a madns release (with hlandau/madns#5 included).

ACKs for commit 06d6ef:

Tree-SHA512: ee385454aef3b802899659db74bbeb28ec6555216f4a4ccfc6047c08f32272080b7f76f851e4b291204ab41525bbfae30e7cdc663b49595d7d5105744810c763
JeremyRand added a commit to namecoin/ncprop279 that referenced this pull request Oct 19, 2019
d49e2ed Add EDNS0 stream isolation (JeremyRand)

Pull request description:

  Fixes #8

  Prerequisites:

  - [x] Merge hlandau/madns#4
  - [x] Merge hlandau/madns#5
  - [x] Tag a madns release (with major version 2).
  - [x] Replace `madns.v1` dependency with `madns.v2`.
  - [x] Tag a madns release (with hlandau/madns#5 included).

ACKs for commit d49e2e:

Tree-SHA512: 540ccb75358b7dbe640f88151d6bee45d625d22aa58558054c81f1f08412d4bfa43a9cb2730a59898d3e4ff0da1c62a610ac266877419a311b4b89ca5dc87b8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants